-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Support building site without CROWDIN_DOCUSAURUS_API_KEY #10804
[Build] Support building site without CROWDIN_DOCUSAURUS_API_KEY #10804
Conversation
|
||
# TODO: remove this after figuring out why crowdin removed code tab when generating translated files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are touching this file, can you move all the cp
commands into a shell function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is nothing related to crowdin. this is just a review comment on the shell script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll extract a shell function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sijie I have now extracted a shell function. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently think this part can be removed, because newer versions since 2.5.2 have not added the corresponding content, but the site is built successfully, so I will consider doing a test to decide whether to remove the hack content
- build English site when key isn't set - this is useful for debugging and improving the Website build
b34f43f
to
aca80df
Compare
…che#10804) * Support building site without CROWDIN_DOCUSAURUS_API_KEY - build English site when key isn't set - this is useful for debugging and improving the Website build * Add review feedback: extract shell function
…che#10804) * Support building site without CROWDIN_DOCUSAURUS_API_KEY - build English site when key isn't set - this is useful for debugging and improving the Website build * Add review feedback: extract shell function
Motivation
The website build is currently broken and there's a need to debug the issues locally in order to fix the problems.
With the PR changes, it's possible to build the site with these commands locally:
Modifications
Support building site without
CROWDIN_DOCUSAURUS_API_KEY